Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reload permission on refresh event #54

Merged
merged 3 commits into from
Mar 27, 2024
Merged

refactor: reload permission on refresh event #54

merged 3 commits into from
Mar 27, 2024

Conversation

vohoanglong0107
Copy link
Contributor

No description provided.

Kobzol
Kobzol reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a good start! The hard part is modifying the refresh logic so that handling of events can proceed concurrently with the refresh. That will require a much larger refactoring of the app (should be left for another PR).

@vohoanglong0107 vohoanglong0107 requested a review from Kobzol March 27, 2024 08:42
Kobzol
Kobzol approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@Kobzol Kobzol merged commit ddc81f0 into rust-lang:main Mar 27, 2024
2 checks passed
@vohoanglong0107 vohoanglong0107 deleted the refactor-reload-permission-on-refresh-event branch March 28, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vohoanglong0107 @Kobzol